Repository navigation
Conversation
Register the late redirect cache flush only after the database installation passes its capability and nonce checks. Ordinary redirects must preserve cache entries and transients. Add regression coverage for anonymous and authenticated redirects, rejected installation requests, and the required flush during an authorized installation. Report: https://hackerone.com/reports/4095826
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin currently flushes the object cache on every WordPress redirect, including redirects for anonymous visitors. With a persistent object cache, this also removes cached transients.
Ordinary redirects now preserve the cache. The late cache flush is registered only after a SQLite installation request passes the permission and nonce checks, so the database-switch redirect still flushes it.
Regression tests cover anonymous and signed-in redirects, rejected installation requests, and the required flush during an authorized installation. Validation included both single-site and multisite plugin suites and a local HTTP reproduction with a persistent object cache.