Skip to content

wcm: print an error and exit on empty <value> elements in metadata #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soreau merged 1 commit into from
Oct 11, 2026
Merged

wcm: print an error and exit on empty <value> elements in metadata #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/metadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,10 +272,20 @@ Option::Option(xmlNode *cur_node, Plugin *plugin)
{
if (n->type == XML_ELEMENT_NODE)
{
std::string elem_name = (char*)n->name;
int is_value = (elem_name == "value");
int is_name = (elem_name == "_name");
if ((is_value || is_name) && !n->children)
{
printf("ERROR: [%s] empty <%s> element in option '%s' "
"description; fix the plugin metadata\n",
plugin->name.c_str(), elem_name.c_str(),
this->name.c_str());
exit(1);
}

if (this->type == OPTION_TYPE_INT)
{
int is_value = (std::string((char*)n->name) == "value");
int is_name = (std::string((char*)n->name) == "_name");
if (!li && (is_value || is_name))
{
li = std::make_unique<LabeledInt>();
Expand All @@ -293,8 +303,6 @@ Option::Option(xmlNode *cur_node, Plugin *plugin)
}
} else if (this->type == OPTION_TYPE_STRING)
{
int is_value = (std::string((char*)n->name) == "value");
int is_name = (std::string((char*)n->name) == "_name");
if (!ls && (is_value || is_name))
{
ls = std::make_unique<LabeledString>();
Expand Down
Loading