Repository navigation
wcm: print an error and exit on empty <value> elements in metadata - #128
Merged
Merged
Conversation
Member
|
To pass CI, click the three dots next to the failure and click 'View details', and there should be a patch there you can apply. |
bornmw
force-pushed
the
metadata-empty-value-error
branch
from
October 10, 2026 17:03
5978cb5 to
4f463fa
Compare
The option desc parser dereferenced n->children->content for <value> and <_name> elements without a null check. An empty <value></value> element (no children) segfaulted wcm at startup. Following the handling accepted in WayfireWM#126: print an error naming the plugin and option, and exit cleanly. The same is_value/is_name computation is now done once before the type branches.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #126, implementing the handling discussed there: print an error and exit instead of segfaulting.
The option
descparser dereferencedn->children->contentfor<value>and<_name>elements without a null check, so an empty<value></value>element segfaulted wcm at startup. The guard now prints an error naming the plugin and the option, and exits cleanly. Theis_value/is_namecomputation is done once before the type branches (identical in both).Verified with a minimal metadata file containing an empty
<value>(run withXDG_DATA_HOMEpointed at a test metadata dir):ERROR: [badplugin] empty <value> element in option 'test_opt' description; fix the plugin metadata, clean exit(1)value/_namepairs) loads and runs as before