Skip to content

Keep stack.css in step, and correct a test count stale since the day it tripled #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Varnasr merged 2 commits into from
Sep 23, 2026
Merged

Keep stack.css in step, and correct a test count stale since the day it tripled #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e2509
Keep stack.css in step, and correct a test count stale since the day …
Varnasr Sep 23, 2026
b24f36d
Take the count from testthat, not from a grep
Varnasr Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,22 @@ assuming a file exports something.
main. No schedule: nothing here touches an external service.

```r
source("tests/run_all_tests.R") # 6 files, 37 checks
source("tests/run_all_tests.R") # 7 files, 119 checks
```

That count was 6 and 37 until 2026-09-23. `field_ops/` arrived in the same
commit that rewrote 41 lines of this file and left the comment alone, so the
repository understated its own suite by more than threefold from the day the
suite tripled. Nothing compares the two.

119 is what testthat reports, not what a grep counts. `run_all_tests.R` uses
the summary reporter, which prints one character per **expectation**, and the
run breaks down as climate_index 3, dhs_stunting 14, education_outcomes 2,
field_ops 82, health_access_index 3, mel_reshape 2, survey_summary 13. A grep
for `expect_` in the same files finds 112, because some expectations sit
inside loops and run more than once. If you update this number, read it off a
run rather than off the source.

Two things to know before adding a test.

**testthat runs from `tests/`, not the repository root.** Use `fs_path()` from
Expand Down
11 changes: 10 additions & 1 deletion assets/css/stack.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,16 @@ a { color: inherit; text-decoration: none; }
transition: background .12s, color .12s; }
.row:hover, .row:focus-visible { background: var(--ink); color: var(--bg); }
.row b { font-weight: 600; font-size: .95rem; }
.row span { font-family: var(--mono); font-size: .66rem; opacity: .7; white-space: nowrap; }
.row span { font-family: var(--mono); font-size: .66rem; white-space: nowrap; }
/* Opacity belongs on the tag, not on every span in the row. `.t` is itself a
span wrapping the title and the tag, so `.row span { opacity: .7 }` applied
twice to the tag (0.7 x 0.7 = 0.49) and once to the title. Measured on the
InsightStack landing page: the tag came out #84827f on #f6f2ea, 3.43:1 at
10.56px, failing AA on 18 elements, and every row title rendered at 70%
opacity, which is the opposite of what `.row b { font-weight: 600 }` is for.
The comment below already records the same selector doing the same thing to
white-space; that was scoped and this was not. */
.row .t > span { opacity: .7; }

/* --- calculator layout --------------------------------------------------- */
.calc { display: grid; grid-template-columns: 1.05fr .95fr; gap: 0;
Expand Down
Loading