Repository navigation
Keep stack.css in step, and correct a test count stale since the day it tripled - #27
Merged
Merged
Conversation
…it tripled
The CSS change is the family's, not this repository's. `.row span
{ opacity: .7 }` matched more than the tag it was written for, because
`.t` is itself a span wrapping the title and the tag, so the opacity
compounded on the tag (0.7 x 0.7 = 0.49) and dimmed the title. Scoped
now to `.row .t > span`.
This landing page had none of it. Counted before the fix: InsightStack
18 elements at 3.43:1, EquityStack 12, SignalStack 7, FieldStack 0,
because this page uses different markup. The file is carried here
because assets/css/stack.css is byte-identical across the four stack
repositories by design and CLAUDE.md says to change it in one place and
copy it. Verified after on all four landing pages: 0 serious or
critical axe violations at 1280x900 and 390x844, no overflow.
The count. CLAUDE.md said "6 files, 37 checks". The suite is 7 files
and 55 test_that blocks. Commit f4ec67d added field_ops/ together with
tests/test_field_ops.R and its 41 test_that blocks, rewrote 41 lines of
CLAUDE.md, and left that comment alone, so the repository has
understated its own suite by roughly a factor of three since the day
the suite tripled.
Not verified by running it: R is not available in this environment, so
the 55 is counted from the source rather than reported by testthat. CI
runs Rscript tests/run_all_tests.R and is green.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
The PR said testthat wins if it disagreed, and it does. CI ran the suite on this branch and its summary reporter printed 119 dots across 7 files: climate_index 3, dhs_stunting 14, education_outcomes 2, field_ops 82, health_access_index 3, mel_reshape 2, survey_summary 13. 119, not the 55 test_that blocks I counted from the source, and not the 112 expect_ calls a grep finds either: the reporter prints one character per expectation, and some expectations sit inside loops and run more than once. So a static count of this suite undercounts it, in both units. That also settles the unit. The original comment said 'checks', which is expectations, so 37 -> 119 compares like with like. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
assets/css/stack.cssis the same file in all three stack repositories and had drifted; this brings it back into step, including the row-opacity fix.CLAUDE.mdsaid the suite was 6 files and 37 checks. It is 7 files and 119 checks.field_ops/arrived in the same commit that rewrote 41 lines of that file and left the comment alone, so the repository understated its own suite by more than threefold from the day the suite tripled.119 is what testthat reports, not what a grep counts: the summary reporter prints one character per expectation and some expectations sit inside loops, so a grep for
expect_finds 112. The number is now read off a run, and the file says so.Type of change
Checklist
source("tests/run_all_tests.R")— 7 files, 119 checksCommits
🤖 Generated with Claude Code
https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
Generated by Claude Code