Skip to content

fix: update uuid to 11.1.1 - #59

Merged
YomiCasual merged 1 commit into
mainfrom
security/update-uuid
Oct 13, 2026
Merged

YomiCasual merged 1 commit into
mainfrom
security/update-uuid

Conversation

@sebd0

@sebd0 sebd0 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Clears the uuid finding (GHSA-w5hq-g745-h8pq, missing buffer bounds check in v3/v5/v6 when a buf is passed). Oneleet lists 13.0.1 as the fix, but the advisory is also fixed in 11.1.1, and 11.x is the last line that still ships a CommonJS build. Since dist/index.cjs does a plain require("uuid"), 13.x (ESM only) would break CommonJS consumers of the SDK, so 11.1.1 is the right target. The code only uses v4 and validate, both unchanged across 9 -> 11.

Stacked on the ws branch (#58) because both touch package-lock.json; GitHub retargets it to main once #58 merges.

Changes

  • uuid ^9.0.1 -> ^11.1.1 (package.json and lock)

Testing

npm ci, npm run lint and npm run build pass. Both build outputs load: require("./dist/index.cjs") and import("./dist/index.js") resolve uuid and export the SDK. npm test has the same 10 failing files as main (heartbeat and connection suites, red on main since June), no change in the set.

@sebd0
sebd0 requested a review from IanLunn September 14, 2026 13:21
@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2513c96c-e068-408d-a4e9-cd1a0e079ec2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sebd0
sebd0 added this pull request to stack #60 September 14, 2026 14:11
@IanLunn
IanLunn requested a review from YomiCasual September 17, 2026 09:33
@IanLunn
IanLunn removed their request for review September 17, 2026 09:33
Base automatically changed from security/update-ws to main October 13, 2026 10:11
@YomiCasual
YomiCasual force-pushed the security/update-uuid branch from 223c981 to bc1b58a Compare October 13, 2026 10:11
@YomiCasual
YomiCasual merged commit e623ea0 into main Oct 13, 2026
1 of 2 checks passed
@YomiCasual
YomiCasual deleted the security/update-uuid branch October 13, 2026 10:12
@YomiCasual YomiCasual mentioned this pull request Oct 13, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants