Repository navigation
fix: update uuid to 11.1.1 - #59
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sebd0
added this pull request to stack #60
September 14, 2026 14:11
IanLunn
removed their request for review
September 17, 2026 09:33
YomiCasual
force-pushed
the
security/update-uuid
branch
from
October 13, 2026 10:11
223c981 to
bc1b58a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the uuid finding (GHSA-w5hq-g745-h8pq, missing buffer bounds check in v3/v5/v6 when a buf is passed). Oneleet lists 13.0.1 as the fix, but the advisory is also fixed in 11.1.1, and 11.x is the last line that still ships a CommonJS build. Since dist/index.cjs does a plain require("uuid"), 13.x (ESM only) would break CommonJS consumers of the SDK, so 11.1.1 is the right target. The code only uses v4 and validate, both unchanged across 9 -> 11.
Stacked on the ws branch (#58) because both touch package-lock.json; GitHub retargets it to main once #58 merges.
Changes
Testing
npm ci, npm run lint and npm run build pass. Both build outputs load: require("./dist/index.cjs") and import("./dist/index.js") resolve uuid and export the SDK. npm test has the same 10 failing files as main (heartbeat and connection suites, red on main since June), no change in the set.