Repository navigation
Archive runware sdk js - #61
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The migration table contains an invalid task type and misrepresents skipResponse behavior.
2 open findings
What changed in this PR
Prepares the final @runware/sdk-js release and guides users toward @runware/sdk.
Changes:
- Adds deprecation and migration guidance.
- Removes SDK-only fields from WebSocket payloads with test coverage.
- Bumps version and builds automatically before publishing.
| File | Description |
|---|---|
Runware/Runware-base.ts |
Sanitizes WebSocket payloads. |
Runware/Runware-server.ts |
Uses shared payload serialization. |
tests/Runware/connection/websocket-payload.test.ts |
Tests payload sanitization. |
readme.md |
Adds deprecation, migration, and changelog notes. |
package.json |
Bumps version and adds prepublish build. |
package-lock.json |
Synchronizes package version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: YomiCasual <60094936+YomiCasual@users.noreply.github.com>

Summary
Final release of
@runware/sdk-js(v1.3.3) before the package is deprecated and this repository is archived in favour of@runware/sdk(runware-typescript).Jira: RUN-12934
Decision (Slack thread, Ian Lunn / Abiodun Onisade / Sebastian Dugudae): archive rather than maintain, but ship the dependency bumps first so users who have not migrated are not left on vulnerable dependencies. End of life date: 2027-01-31.
Changes
readme.md: redCAUTIONblock with the end-of-life date and a link to the migration section.readme.md(before/after example plus a method mapping table), derived from the TypeScript SDK docs. No migration notes existed anywhere else.1.3.2→1.3.3(final).package-lock.jsonregenerated on top of the merged dependency bumps; it differs frommainonly by the version lines.prepublishOnly: npm run buildso a publish can never ship a staledist/.serializeWebsocketMessagestrips the SDK-onlyskipResponseandadditionalPropertiesfields before they reach the wire (Runware/Runware-base.ts,Runware/Runware-server.ts), with a unit test intests/Runware/connection/websocket-payload.test.ts.readme.md.Already merged to
mainahead of this PR: #58 (ws8.18.0 → 8.21.3) and #59 (uuid^9.0.1 → ^11.1.1, the lastuuidline with a CommonJS build).Verification
npm run lint: clean (only pre-existing errors in the gitignoredtests/script.ts).npx vitest run tests/Runware/connection/websocket-payload.test.ts tests/Runware/retry: 6/6 pass. The other test files need a realAPI_KEYand fail in CI on every branch, includingmain; that is not a regression from this PR.npm run build: ESM + CJS + types build.npm pack --dry-run: 8 files,dist/*,package.json,readme.mdonly.require("./dist/index.cjs")andimport("./dist/index.js")both load and resolveuuid11.1.1.npm audit --omit=dev: 0 vulnerabilities.npm ls ws uuid: 8.21.3 / 11.1.1.Release checklist (after this PR is merged, in this order)
1. Publish v1.3.3 to npm
Owner: whoever holds publish rights on
@runware/sdk-js. Requiresnpm loginfirst.git checkout main && git pull --ff-only && npm cinpm whoami(confirm the account has publish rights)npm publish(prepublishOnlyruns the build)npm dist-tag add @runware/sdk-js@1.3.3 beta(so@betano longer resolves to 1.3.2-beta.1)npm view @runware/sdk-js version dist-tagsshowslatest: 1.3.3,beta: 1.3.32. Tag and GitHub release
git tag v1.3.3 && git push origin v1.3.3gh release create v1.3.3 --title "v1.3.3 (final release)" --notes-file <changelog excerpt>3. Deprecate the package on npm
This single command puts the red "deprecated" banner on npmjs.com and prints
npm WARN deprecatedon every install, which covers both "update the deprecation notice" and "warning on npm install" from the ticket. Deprecate all versions, including 1.3.3, otherwise the version everyone installs stays silent.Run:
npm view @runware/sdk-js deprecatedreturns the messageIn a scratch directory,
npm init -y && npm i @runware/sdk-jsprints thenpm WARN deprecatedlineUndo if the wording needs changing:
npm deprecate "@runware/sdk-js@*" ""4. Notify internal consumers
These repos still depend on
@runware/sdk-jsand will start seeing the install warning. Comment on RUN-12934 with the migration link so their owners are not surprised:Runware/fe-playgroundRunware/runware.ai-websiteRunware/incubatorRunware/dash-v0Runware/fastsd3.runware.ai-websiteArchiving does not block them: the npm package stays installable, only the GitHub repo becomes read-only.
5. Archive the repository (last step)
Needs an org admin on
Runware/sdk-js. Do this only after everything above is done, because an archived repo rejects pushes.@runware/sdk)gh repo archive Runware/sdk-js -y(or Settings → Danger Zone → Archive this repository)If a regression in 1.3.3 surfaces after archiving
Unarchive → fix → publish 1.3.4 → re-run the deprecate command → re-archive.