Conversation
This was referenced Sep 28, 2026
# Conflicts: # docs/design_docs/physical-operators.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Structural and synthetic-ranking tests did not prove that each admitted physical candidate could be compiled into deployment plans, installed, fed data, and return the expected query results. Testing only the default winner could leave other legal candidates unexecuted.
After this PR
For each individual query and query ensemble, enumerate admitted physical candidates and change synthetic costs to make each candidate win. Compile the selected Physical DAGs into deployment plans, install them, ingest Remote Write data, drain precompute, and compare query results with Prometheus. Each ensemble shares one installation per candidate.
This is the data-plane acceptance step after #728 (candidate structure) and #742 (synthetic ranking). It does not measure production costs or implement online ERP/replanning.
Alignment with #737
Validation
The dataset-bound rerun passed 23 candidate executions and 66 query comparisons, covering all ten individual queries, shared-rate, shared-quantiles, and the full ten-query ensemble. These are all admitted fixture candidates; rejected candidates and their reasons remain visible. This is not a claim to cover every theoretical physical plan.
Also passed: four Level 1 tests, full synthetic Level 2 ranking, focused dataset/install/recovery/warm-up/query-fence tests, and strict all-target Clippy. Deferred test branches compile; their production-cost acceptance has not been rerun.
Candidate admission reports and human-review instructions. Generated archives are kept outside version control.
Run
make candidatesinpromql-compliance/runner. Plan exports support human review; automated success does not replace it.Additional regression: individually certified quantile readouts do not certify their ratio. Deployment admission checks the complete query guarantee and rejects uncertified compositions before pricing or installation.