Conversation
This was referenced Sep 23, 2026
Open
Add runtime debug logs across plan publication and query execution
ProjectASAP/ASAPQuery-backend#756
Open
zzylol
marked this pull request as ready for review
September 24, 2026 13:13
zzylol
force-pushed
the
feat/shared-physical-operators
branch
from
September 24, 2026 14:28
50a3972 to
9ceeba7
Compare
zzylol
force-pushed
the
refactor/membership-subgraph
branch
from
September 24, 2026 14:28
ad95c6d to
12ccae2
Compare
zzylol
force-pushed
the
refactor/membership-subgraph
branch
from
September 24, 2026 14:49
12ccae2 to
0afd38a
Compare
zzylol
force-pushed
the
feat/shared-physical-operators
branch
2 times, most recently
from
September 24, 2026 15:00
2b6171a to
9463710
Compare
zzylol
force-pushed
the
refactor/membership-subgraph
branch
2 times, most recently
from
September 24, 2026 15:08
36e7da7 to
da6ecbf
Compare
zzylol
force-pushed
the
feat/shared-physical-operators
branch
2 times, most recently
from
September 24, 2026 16:05
d782c4e to
0349523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
ASAPPlanner selected logical computations, while deployments implemented physical operators and execution separately. There was no shared library to keep Planner semantics, operator behavior and shared-producer execution consistent.
After this PR
Add
asap-physical-operators: native relational and summary operators, a physical compiler, and a runtime for one DAG execution.Planner owns operators, dependencies, sharing and materialization frontiers. Backend owns deployment feasibility, runtime-statistics/resource/ERP costing, storage bindings and scheduling. Build, merge and readout are reusable operators, not fixed deployment phases. See the design.
The library includes:
asap_sketchlib.Validation
Operator, physical-DAG and Planner-to-execution tests cover schemas, errors, resources, independent runs, shared dependencies and serialization. Latest physical-package run passed 320 tests including its documentation test; two additional identity/resource tests and the final weighted/current-series suites also pass. Strict all-target Clippy passes.
The weighted binding suite passes eight tests, including both grouped Rate/Sum placements and raw samples through Rate and both heap families. Coverage includes resets, zero scores, shifted windows and unreferenced labels. Current-series tests cover decreases, expiry, stale markers, conflicting timestamps and recovered physical programs. These are shared-library tests, not deployment E2E.
Integration limits
Backend #761 installs and costs native physical candidates for SQL, spatial TopK, Rate TopK and grouped Rate/Sum. Certified deployment tests execute query-time and precomputed CMS/CountSketch heaps and grouped Sum through durable SDS, HTTP and restart. Precomputed aggregates require finite complete-input closure; overlapping full windows preserve the query cadence. #728 now retains 10 selected plans and 34 compiled candidate plans, including both Sum placements, for human review. Other PromQL shapes retain documented Backend adapters; joint workload candidate search remains bounded rather than exhaustive.
General scalar-output persistence, distributed execution, sharding and spill remain outside the established deployment path. Ad-hoc SDS discovery is deferred. No new manual deployment verification or human plan approval is claimed. The previously recorded Level 3 performance gate remains failed.