Conversation
|
I ddded the following:
|
|
@milindsrivastava1997 Thanks for the logging suggestion. I made the controller and data plane consistent: both now use only I also expanded the installed query DAG events so every evaluated node reports its IR type ( |
90154af to
6a9dc9c
Compare
# Conflicts: # control_plane/src/physical/compiler.rs
# Conflicts: # crates/asap_types/src/query_plan/native.rs
Problem and behavior
Before this PR: following a request across planning, deployment, shared execution and SDS required unrelated logs with incomplete node and state identities.
After this PR: optional
asap_runtime_debugevents identify the actual stage: Planner selection, backend candidate admission/cost selection, deployment binding/activation, shared DAG execution, SDS publication, bound lookup/validation, and recovery. Candidate events include status, cost, rejection reason and search coverage. State events distinguishstored_output_idfromdefinition_id; execution events identify dependencies and inclusive node duration. Failed bound reads use debug-level error events.Use
RUST_LOG=info,asap_runtime_debug=debugin both processes. Call IDs are process-local. The architecture/stage table and correlation limits are documented indocs/runtime-debugging.md. Diagnostics describe the implemented path; they do not certify exhaustive physical-candidate generation or change selection behavior.Stack
Based on #761 to instrument its current runtime-evidence costing path. #756 and #766 are independent follow-ups; correctness/evaluation PRs do not depend on this diagnostics PR. Shared operators come from ASAPPlanner #462.
Validation
Strict all-target Clippy passes on the current merged branch. The #761 base passes 120 type, 448 control-plane and 896 data-plane unit tests, nine native candidate tests, and six real-process Rate aggregation/restart tests. Those base checks validate execution semantics; the diagnostic spans report stages without changing them.
Native maintenance, stored-summary binding and bound-native lookup now have distinct spans. Documentation covers grouped Sum and CMS/CountSketch heaps, both placements, and overlapping complete windows. Logs expose selected execution, not an exhaustive-search or performance claim.
Closes #755.