Skip to content

Fix/erc20 bridgeable invalid sender - #400

Merged
maxnorm merged 3 commits into
Perfect-Abstractions:mainfrom
Jayy4rl:fix/erc20-bridgeable-invalid-sender
Sep 19, 2026
Merged

maxnorm merged 3 commits into
Perfect-Abstractions:mainfrom
Jayy4rl:fix/erc20-bridgeable-invalid-sender

Conversation

@Jayy4rl

@Jayy4rl Jayy4rl commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Bridgeable mod and facet reverts ERC20InvalidReceiver for this check

 if (_from == address(0)) {
            revert ERC20InvalidReceiver(address(0));
        }

Changes Made

Edited the revert in both facet and mod to revert ERC20InvalidSender. The error cascaded into the tests, so i edited that too in the unit tests and the trees.

Closes #398

@netlify

netlify Bot commented Sep 16, 2026

Copy link
Copy Markdown

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 56ac1de

@changeset-bot

changeset-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 56ac1de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@perfect-abstractions/compose Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage

Metric Coverage Details
Lines 84% 3024/3602 lines
Functions 91% 721/789 functions
Branches 79% 352/446 branches

Last updated: Sat, 19 Sep 2026 14:21:01 GMT for commit 56ac1de

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Gas Report

No gas usage changes detected between main and fix/erc20-bridgeable-invalid-sender.

All functions maintain the same gas costs. ✅

Last updated: Sat, 19 Sep 2026 14:21:52 GMT for commit 56ac1de

@maxnorm

maxnorm commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@Jayy4rl Please include a changeset file with a patch bump. This will add your changes in the next library release log.

You can run the command locally with npx @changesets/cli in the root folder

Thanks for finding this!

@maxnorm

maxnorm commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Hi @Jayy4rl, i added the changeset file and will merge this.

Thank you for finding this issue!

@maxnorm
maxnorm merged commit 3834700 into Perfect-Abstractions:main Sep 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Crosschain Burn Error Selector

2 participants