Repository navigation
fix(otel): enable gzip and https OTLP export - #4399
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@johntmyers @elezar PTAL when you get a chance, and |
|
@krishicks can you take a look? |
|
/ok to test 325922a |
|
Label |
PR Review StatusThe independent code review found no blocking findings in this focused fix for gzip and HTTPS OTLP export. The shared exporter, TLS/gzip collector test, and gateway configuration docs cover the intended change. @ericcurtin, I checked your request to authorize testing and posted Action required: A maintainer must approve Trivy Changes, which currently reports Blocking findings: None. Carried findings: None. Gator metadata
|
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Thanks @rhuss. Added a negative TLS test (untrusted server cert must fail to export) and shared the setup between the two tests. @johntmyers @krishicks PTAL, and |
|
/ok to test aecc4d2 |
PR Review StatusThe independent follow-up review found no blocking findings in the new TLS rejection test and shared test setup. @ericcurtin, I checked your update addressing the negative TLS test suggestion: the new case uses an unrelated signing CA and requires export to fail with no spans received, while the trusted TLS/gzip case still requires a successful export. I posted Action required: A maintainer must approve Trivy Changes, which reports Blocking findings: None. Carried findings: None. Gator metadata
|
|
@ericcurtin resolve comments if they have been addressed, then it should queue to merge |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: Gator found no blocking review findings, and maintainer approval was present before merge. I removed the active Gator metadata
|
Summary
Enable gzip and
https://OTLP export. Both failed at startup.Related Issue
Closes #3899
Changes
gzip-tonic,tls-aws-lc,tls-rootsonopentelemetry-otlp.https://endpoints (tonic trusts none by default).https://andOTEL_EXPORTER_OTLP_COMPRESSION=gzip.Testing
cargo fmt,cargo clippyandcargo testforopenshell-otel,openshell-otel-test-support, and the Docker driver OTLP test.mise run docspasses. The new test fails withUnknownIssuerwithout the roots change.Checklist