Skip to content

Add pgp-key and pgp-message object templates - #543

Merged
adulau merged 1 commit into
mainfrom
codex/pgp-key-message-objects
Oct 15, 2026
Merged

adulau merged 1 commit into
mainfrom
codex/pgp-key-message-objects

Conversation

@adulau

@adulau adulau commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Add pgp-key for public-key armor, fingerprints, complete UIDs and HKP index metadata, and pgp-message for armored or binary message/signature artifacts. Both pair with the existing pgp-meta object through pgp-meta --extracted-from--> pgp-key or pgp-message relationships.

pgp-key requires a key ID so metadata can be retained when public-key retrieval fails. pgp-message requires either message or message-file. Both templates use existing MISP attribute types and default new attributes to to_ids=false. The existing pgp-meta template and relationship definitions are unchanged.

Companion keyserver expansion: MISP/misp-modules#936.

Validation:

  • All 447 object templates and the relationship definitions pass JSON schema validation; template UUIDs are unique.
  • New definitions match jq -S -j formatting and the expansion module's bundled copies.
  • Relationship name/opposite checks pass.

The validate_all.sh wrapper could not complete locally because sponge and uuidparse are unavailable; its schema, formatting, UUID and relationship checks were run separately.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T13:02:54.638543Z a69fbba PR opened
🔒 Security Review ✅ Completed 2026-10-15T13:03:41.987243Z a69fbba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@adulau
adulau merged commit 5687a70 into main Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant