Repository navigation
Add PGP keyserver expansion for key IDs and UID metadata - #936
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d642ea4cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
pgp_keyserverexpansion/hover module that queries an HKP keyserver by key ID, fingerprint, email address or UID text, usinghttps://pgp.circl.luby default.Return one
pgp-keyand onepgp-metaobject per result, linked withextracted-from, while preserving the original attribute. Keep complete UIDs, key IDs, fingerprints, dates, flags and provenance; retrieve public-key armor by full fingerprint and retain index metadata when a download fails. Queries, response sizes and result counts are bounded, with configurable keyserver, timeout and result limit. Accept HKP indexes without the optional information record and with omitted trailing empty fields; absent versions default to 1 and missing result counts are derived locally.Bundle the new object templates for older PyMISP releases and include usage documentation, a message/metadata relationship example and regression tests. MISP-side installation requires the templates merged in MISP/misp-objects#543. The existing
pgp-metatemplate is unchanged.Validation:
pytest -q tests/test_pgp_keyserver.py: 105 passed.UID matching depends on the server's index; CIRCL returned no matches for the tested name-only and complete-UID queries. Keyserver claims and public-key armor are not cryptographically verified.
pgp-messageis an artifact template with an example; this module does not parse or decrypt messages.