Repository navigation
Add ptrclassify MISP object template - #538
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion module integration: MISP/misp-modules#918
Add a
ptrclassifyMISP object template for the heuristic classification of one PTR-style hostname. It holds the queried IP when available, matched status, repeated classification labels with confidence/evidence/rule IDs, potential location candidates, embedded-IP/cloud-region/conflict hints, and classifier version.Repeated classification fields use the machine tag as their attribute comment; location fields use a rule-ID/code comment. This keeps multiple labels and location hints associated within one object per hostname. Generated attributes default to
to_ids=false, and generic classification fields disable correlation. The template explicitly describes the limits of PTR-based inference and location hints.The module integration will use the existing
dns-recordtemplate for observed reverse-DNS owners and PTR targets, retaining taxonomy tags on the queried attribute and PTR answers. The module bundles an identical copy of this template for PyMISP releases that do not yet ship it.Validation:
./validate_all.shpassed, including JSON normalization, all object and relationship schemas, relationship tests, and UUID uniqueness. The module's wheel was verified to contain the identical template, and its structured outputs passed strict PyMISP template validation.