Repository navigation
Return ptrclassify and DNS record objects for PTR enrichment - #918
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion object template: MISP/misp-objects#538
Replace standalone classification text and discovered hostname attributes with structured MISP objects. Return one
ptrclassifyobject per classified hostname, with repeated classification, category, label, confidence, evidence and rule-ID fields, plus structured location candidates and classifier hints. Attribute comments identify the label or location candidate associated with each repeated field.For IPv4/IPv6 lookups, return one
dns-recordobject containing the reverse-DNS owner inqueried-domainand all distinct targets inptr-record. Do not infer forward A/AAAA observations. Classification objects characterize the original attribute and reference the DNS object withderived-from; the DNS object references the queried attribute withrelated-to.Preserve the input UUID, existing tags and detection flag. Matching taxonomy tags remain on the queried attribute and each corresponding PTR answer. Newly generated object attributes use
to_ids=false; unmatched names return aptrclassifyobject withmatched=0. Hostname/domain inputs are classified locally without creating a DNS observation.Includes the new ptrclassify template as a packaged JSON asset for compatibility with older PyMISP releases, updated JSON documentation and examples, and regression tests. MISP instances should install the new object template to manage/import it in the UI.
Validation:
Live external PTR lookup remains unavailable in the cloud environment; deterministic DNS responses cover IP enrichment.