Bump MedtrumKit to 85a61c2 - #486
Open
ps2 wants to merge 1 commit into
Open
Conversation
Brings next-dev up to MedtrumKit dev through 3ad0979, the revision LoopWorkspace/dev pins (#2), plus the async alert call site adaptations that merge needed (#3). Chiefly upstream bug fixes that next-dev users do not have: BLE write thread-safety, a duplicated reservoir notification fix, prevention of deactivation while a bolus is in progress, and the LoopKit alerts rework. The eight MedtrumKit commits beyond 3ad0979 are deliberately excluded as potentially experimental.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
next-devup to MedtrumKitdevthrough3ad0979— the revisionLoopWorkspace/devpins — plus the async alert call-site adaptations that merge required.devthrough3ad0979intonext-devWhat comes in
21 upstream commits, chiefly bug fixes
next-devusers do not currently have:feat: make ble write thread-safefix: prevent duplicated reservoir notify(Update LoopWorkspace to 3.5.0 dev Loop #157)feat: prevent deactivation while bolus is in progress(Release 3.4 #151)Centralize navigation titles in coordinator(Alive #148)chore: migrate to sync(Loop sync #138), plus i18n updatesThe eight MedtrumKit commits beyond
3ad0979are deliberately excluded as potentially experimental.Verification
Clean build of the workspace against
85a61c2with fresh derived data — BUILD SUCCEEDED.Not exercised on Medtrum hardware. The alerts rework is the largest behavioural change here, and the adaptation in #3 changes when alerts are issued relative to pump events — both delegate calls now run inside a single
Taskto preserve their prior ordering. Someone with a Medtrum pump confirming that alerts still issue and retract as expected would be worthwhile before this reaches wider testing.