Bump LibreLoop to 1eeb710 - #487
Merged
Merged
Conversation
Scan help now says to hold the TOP of the phone against the sensor, not the back. The NFC antenna is at the top, so the old instruction did not work, and it contradicted the sibling screen which already said "top" (#11, reported by Mike Plante). Also enables Swift string extraction on the LibreLoop and LibreLoopUI targets, matching MinimedKit and OmnipodKit. LibreLoop already declared LocalizedString as an extractable macro and preferred string catalogs but never switched extraction on, so new strings did not reach the catalog. The first build after enabling it harvested 15 strings that had never been available for translation, from the stream debug view and the chart labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up LibreLoop#11.
Scan help: TOP, not back
The NFC antenna is at the top of an iPhone, so "Hold the BACK of your phone against the sensor" did not work — and it contradicted the sibling screen, which already said "top". Reported by @MikePlante1.
Swift string extraction enabled
LibreLoop already declared
LocalizedStringas an extractable macro and preferred string catalogs, but never enabled "Use Compiler to Extract Swift Strings" — the one setting MinimedKit and OmnipodKit both have:So new strings never reached the catalog on their own. The first build after enabling it harvested 15 strings that had never been available for translation — stream debug view and chart labels.
Verification
Clean build of the workspace with fresh derived data — BUILD SUCCEEDED. The LibreLoop catalog stays clean afterwards, so the committed content matches what a build produces.
Contains only the LibreLoop gitlink; the MedtrumKit bump is separate in #486.