Kanban 2052: Match manifest lookup on LABKEY_VERSION's major.minor - #196
Merged
Conversation
…sion (Kanban #2052) fetch-manifest listed the whole product prefix and assumed exactly one manifest lived there. That broke once develop bumped 26.9->26.10 and both versions' manifests coexisted in S3 - old manifests stay (deleting them would break reproducing an older install), so the lookup now filters to the manifest matching LABKEY_VERSION's leading major.minor.
labkey-jony
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
fetch-manifest listed the whole S3 product prefix and assumed exactly one manifest lived there. Develop bumping 26.9->26.10 broke that assumption - both versions' manifests now coexist under the same prefix, and old ones stay by design (needed to reproduce an older install). The lookup now filters to the manifest matching LABKEY_VERSION's leading major.minor.
Related Pull Requests
Changes
Makefile: fetch-manifest filters S3 keys to LABKEY_VERSION's major.minor before checking for exactly one match