26.9: Fetch LIMS product manifest, matched on version (Kanban #2052) - #197
Merged
labkey-willm merged 2 commits intoSep 1, 2026
Merged
Conversation
… builds Only runs under TeamCity (this is a public repo) or with FETCH_LIMS_MANIFEST=1 for local testing, and no-ops for any LABKEY_DISTRIBUTION with no manifest published, since it lists the product's S3 prefix rather than assuming one exists. Overwrites startup/manifest.properties, which previously carried no real content (just the LABKEY_STARTUP_DISTRIBUTION_EXTRA envsubst placeholder).
…sion (Kanban #2052) fetch-manifest listed the whole product prefix and assumed exactly one manifest lived there. That broke once develop bumped 26.9->26.10 and both versions' manifests coexisted in S3 - old manifests stay (deleting them would break reproducing an older install), so the lookup now filters to the manifest matching LABKEY_VERSION's leading major.minor.
labkey-jony
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Backports the fetch-manifest mechanism (#195) and its major.minor version fix (#196) to release26.9-SNAPSHOT together, since this branch never had #195 at all. Needed once distributions#614 (the #613 backport to 26.9) lands and publishes manifests for this branch's LabKey version.
Related Pull Requests
Changes
Makefile: adds fetch-manifest (cherry-picked from Kanban 2052: fetch the matching LIMS product manifest during TeamCity builds #195) with the major.minor version filter already applied (from Kanban 2052: Match manifest lookup on LABKEY_VERSION's major.minor #196), so the two never diverge