Skip to content

Migrate WGPU sonar backend from DAVE #44 - #6

Draft
yeseorizi wants to merge 26 commits into
mainfrom
port/dave-pr44-wgpu
Draft

yeseorizi wants to merge 26 commits into
mainfrom
port/dave-pr44-wgpu

Conversation

@yeseorizi

Copy link
Copy Markdown
Collaborator

Purpose and provenance

Continue the WGPU sonar work in POSIM without replacing the current main tree.

  • Original contribution and discussion: IOES-Lab/dave#44, opened by Naitik Pahwa (@naitikpahwa18).
  • Source head: ca60ba63dcdf60cb76d231255570106e43024862.
  • POSIM baseline merged into that branch: e05a9fb7d25ec21399f897e9bddfcabc4493b703.
  • All 21 commits listed by the source PR remain in the ancestry with their original SHAs and author metadata, including subsequent contributions by Woen-Sug Choi and Yeseol Gwon. Original comments and reviews remain linked in DAVE; they are not recreated under another author's name.

What is carried over

The WGPU Rust/vendor package, compute shaders, C++ backend integration, optional CUDA support, BlueView model settings, demo guides, and existing range-axis validation assets. The current code includes later changes beyond the original PR description; this migration does not claim CPU fallback or new cross-platform runtime results.

POSIM integration decisions

  • Keep POSIM's main-based workflows, ioeslab/posim image naming, repository manifests, documentation and installer fallback URL.
  • Do not reintroduce the DAVE-only PR-image publisher or Pages deployment.
  • Resolve the workflow conflicts in favor of POSIM's current policy; combine the source installer/Docker changes with POSIM branding and repository paths.
  • Result: 38 changed files against the pinned POSIM baseline. The 36 source feature files outside the two workflows, ARM64 Dockerfile and installer are byte-identical to the source PR head.

Checks and remaining work

  • Original source head and every listed source PR commit are ancestors of this branch.
  • Current POSIM baseline is an ancestor; POSIM workflows and repository manifests are unchanged.
  • git diff --check, changed Python syntax and installer Bash syntax pass.
  • Four changed package XML files parse. The unchanged BlueView SDF uses the existing gz: extension; a generic XML parser reports an unbound-prefix warning. SDF/runtime validation is still required.
  • Resolve integration with POSIM #5. A non-mutating merge preview finds an ARM64 Dockerfile conflict between the inherited ArduPilot retry block and Validate POSIM images and fix Docker runtime shutdown failures #5's runtime-image changes. Neither branch has been overwritten.
  • Build and validate the POSIM-integrated sonar on the intended backends; retained validation assets are historical evidence, not a new test run.

Draft / CI note: migration commits use [skip ci] to avoid automatically starting long self-hosted builds before the imported code is reviewed. Repository CI/publication settings were not changed. Before marking this ready, push a follow-up commit without the skip marker and run the required CI/runtime checks. This PR is not a merge-ready or image-publication claim.

The original DAVE PR remains open until the migration is reviewed and closure is coordinated.

naitikpahwa18 and others added 26 commits March 17, 2026 02:03
Signed-off-by: Naitik Pahwa <naitikpahwa11@gmail.com>
Signed-off-by: Naitik Pahwa <naitikpahwa11@gmail.com>
Signed-off-by: Naitik Pahwa <naitikpahwa11@gmail.com>
Signed-off-by: Naitik Pahwa <naitikpahwa11@gmail.com>
Signed-off-by: Naitik Pahwa <naitikpahwa11@gmail.com>
Signed-off-by: Yeseol Gwon <172019512+yeseorizi@users.noreply.github.com>
Signed-off-by: Yeseol Gwon <172019512+yeseorizi@users.noreply.github.com>
Updated Docker configuration step for better clarity and error handling.
ci: fix Node 20, lint permission, and formatting annotations
Signed-off-by: Yeseol Gwon <172019512+yeseorizi@users.noreply.github.com>
Publish macOS loader paths for both sonar libraries and replace the two byte-copy cv_bridge conversions with a local ROS image copy. This avoids unnecessary OpenCV ABI coupling while preserving BGR8 and RGB8 message output.

Signed-off-by: Yeseol Gwon <172019512+yeseorizi@users.noreply.github.com>
Preserve the original wgpu_integration commits and authors, and merge POSIM main e05a9fb. Retain POSIM workflows, manifests and branding; exclude DAVE-only PR-image publishing and Pages deployment. This is a draft migration, not runtime validation. Source: IOES-Lab/dave#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants