Skip to content

mono - chore: upgrade TypeScript and build tooling #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredwray merged 1 commit into from
Oct 13, 2026
Merged

mono - chore: upgrade TypeScript and build tooling #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@biomejs/biome": "^2.5.15",
"@faker-js/faker": "^10.6.0",
"@testing-library/react": "^16.3.3",
"@types/node": "^22.20.1",
"@types/node": "^22.20.5",
"@types/react": "^19.2.18",
"@vitest/coverage-v8": "^5.0.3",
"dotenv": "^17.4.2",
Expand All @@ -57,7 +57,7 @@
"react-dom": "^19.2.8",
"rimraf": "^6.1.3",
"tsd": "^0.33.0",
"tsdown": "^0.22.14",
"tsdown": "^0.23.0",

@gemini-code-assist gemini-code-assist Bot Oct 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The upgraded tsdown@0.23.0 (and its dependency rolldown-plugin-dts@0.28.6) specifies a Node.js engine requirement of ^22.18.0 || ^24.11.0 || >=26.0.0. However, the project's engines.node in package.json is currently set to >=22.12.0. This mismatch can lead to installation warnings or failures for environments running Node.js versions between 22.12.0 and 22.17.x. Please update the engines.node field in package.json to >=22.18.0 to align with the new build tooling requirements, or revert tsdown to 0.22.14 if support for older Node 22 versions is required.

@cursor cursor Bot Oct 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdown@0.22.14 already set engines.node to ^22.18.0 || >=24.11.0. tsdown@0.23.0 keeps that Node 22 floor and adds || >=26.0.0. The gap with package.json:44 (>=22.12.0) was already there.

engines.node is the runtime contract for people who install this SDK. tsdown is a devDependency, so raising that field here would drop Node 22.12 through 22.17 for consumers who never run the build tool. This pull request keeps the declared Node 22 line and does not move it to follow a devDependency.

"typescript": "^7.0.2",
"vitest": "^5.0.3"
},
Expand Down
Loading
Loading