Repository navigation
mono - chore: upgrade TypeScript and build tooling - #81
Conversation
Bump tsdown to 0.23.0 and @types/node to 22.20.5, the newest Node 22 types release that passes the 7-day age gate. Co-authored-by: Jared Wray <me@jaredwray.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies in package.json and pnpm-lock.yaml, notably upgrading @types/node to ^22.20.5 and tsdown to ^0.23.0. Feedback highlights a potential Node.js version mismatch: the upgraded tsdown (and its dependency rolldown-plugin-dts) requires Node.js ^22.18.0 || ^24.11.0 || >=26.0.0, whereas the project's engines.node configuration is set to >=22.12.0. It is recommended to update the project's Node.js engine requirement to >=22.18.0 or revert the tsdown upgrade to avoid installation warnings or failures in older Node.js environments.
| "rimraf": "^6.1.3", | ||
| "tsd": "^0.33.0", | ||
| "tsdown": "^0.22.14", | ||
| "tsdown": "^0.23.0", |
There was a problem hiding this comment.
The upgraded tsdown@0.23.0 (and its dependency rolldown-plugin-dts@0.28.6) specifies a Node.js engine requirement of ^22.18.0 || ^24.11.0 || >=26.0.0. However, the project's engines.node in package.json is currently set to >=22.12.0. This mismatch can lead to installation warnings or failures for environments running Node.js versions between 22.12.0 and 22.17.x. Please update the engines.node field in package.json to >=22.18.0 to align with the new build tooling requirements, or revert tsdown to 0.22.14 if support for older Node 22 versions is required.
There was a problem hiding this comment.
tsdown@0.22.14 already set engines.node to ^22.18.0 || >=24.11.0. tsdown@0.23.0 keeps that Node 22 floor and adds || >=26.0.0. The gap with package.json:44 (>=22.12.0) was already there.
engines.node is the runtime contract for people who install this SDK. tsdown is a devDependency, so raising that field here would drop Node 22.12 through 22.17 for consumers who never run the build tool. This pull request keeps the declared Node 22 line and does not move it to follow a devDependency.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore. Upgrades TypeScript and build tooling.
Summary
tsdownmoves to the Latest version frompnpm outdated.@types/nodestays on the Node 22 line fromengines.node(>=22.12.0). The newest aged 22 release is 22.20.5, not the 26.x Latest column.Changes
tsdownfrom 0.22.14 to 0.23.0@types/nodefrom 22.20.1 to 22.20.5Verification
pnpm build && pnpm testpasses on Node 22.23.3 (15 tests, build succeeded)Artifact diffs