fix(rendering): complete core rendering integrity - #782
Merged
Merged
Conversation
Bundle ReportChanges will decrease total bundle size by 20.18MB (-37.44%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: exo-full-iife-Exo-iifeAssets Changed:
Files in
view changes for bundle: exo-iife-Exo-iifeAssets Changed:
Files in
view changes for bundle: exo-full-iife-min-Exo-iifeAssets Changed:
Files in
view changes for bundle: exo-esm-esmAssets Changed:
Files in
view changes for bundle: exo-esm-modules-esmAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
Files in
view changes for bundle: site-server-esmAssets Changed:
App Routes Affected:
view changes for bundle: exo-iife-min-Exo-iifeAssets Changed:
Files in
|
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core rendering counted retained batches that never drew, traversed culled subgroups on the persistent-slot path, and maintained separate NineSlice/repeating renderer resources. This change restores selection-tier culling and replay counter parity, shares scalable sprite geometry batches on both backends, and publishes valid benchmark comparisons without scenario-level withholding.
culledNodessemantics.falsewhen they issue no draw. Existing void-returning SDK replayers retain descriptor-based accounting; both backends count submitted nodes consistently.Validation: new regression tests were observed failing before their fixes. All 44 existing NineSlice/repeating pixel, retained and state browser tests passed before and after consolidation. Additional named replay, persistent-slot, shader/precision, cross-backend parity, structural and allocation tests pass. Typecheck, lint/format, sync and site checks pass, including the 911-file test typecheck and fresh-build export validation. Independent review findings were fixed and covered by regressions.
Naga is unavailable locally, so its 36 remaining validation cases were skipped; real browser shader compilation passed. No timing improvement or mobile-hardware result is claimed. Native
GPURenderBundlesupport is deferred pending representative batch-count and CPU encoding/replay evidence; no native-bundle implementation or reference benchmark run is included. No version bump or release changes.Pre-push follow-up: obsolete NineSlice resource-label filters in cache tests were corrected to the shared renderer labels, retaining all cache expectations and adding a red/green positive control to the browser test. All 25 static gates, the unit/allocation/physics-performance lane and the WebGL/build/assets/core browser lane passed. The aggregate WebGPU run stalled and was interrupted after about 8.5 minutes, reporting 100 completed files and 613 passing tests; the outstanding text-shaping parity file then passed all 6 tests in isolation. This is not a passing aggregate WebGPU lane. Benchmark-structural and site/example-smoke lanes were not reached by the hook. The owner authorized a one-time push without the local hook; complete CI validation remains required before merge. Auto-merge is disabled.