Conversation
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: c73740e | Docs | View more details | Give us feedback! |
11 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps the bundled
dd-traceto the releases carrying the Lambda response-body-to-WAF work (6.17.0/5.128.0).Motivation
The layer needs to bundle a
dd-tracethat actually publishes the response body to the WAF for thedatadog-lambda-jsside of this feature (#825) to have any effect.Testing Guidelines
yarn test(728 tests, 54 suites, all green), yarn build (clean tsc), yarn lint (no warnings). Confirmed viayarn.lockthatdd-traceresolves to6.17.0andimport-in-the-middleto3.5.1with no resolution warnings.Additional Notes
Also drops the
import-in-the-middleresolutions override pinning it to3.4.0: that pin existed because3.5.0brokeesbuild(#835), and both new dd-trace releases now hard-pinimport-in-the-middle@3.5.1themselves (the release that fixes that exact regression upstream).Types of Changes
Check all that apply