Skip to content

fix(ci): tolerate AWS Lambda base-image drift in the local integration suite - #841

Open
CarlesDD wants to merge 1 commit into
mainfrom
ccapell/tolerate-lambda-image-drift
Open

CarlesDD wants to merge 1 commit into
mainfrom
ccapell/tolerate-lambda-image-drift

Conversation

@CarlesDD

Copy link
Copy Markdown
Collaborator

What does this PR do?

public.ecr.aws/lambda/nodejs:22 and :24 were updated under their floating tags, and the new images changed runtime behavior the local Docker/RIE integration suite pins as goldens:

  • The updated images emit a new runtime_worker_pool_initializing debug log record. Its workerCount field reflects the container's visible CPU count, not anything the library controls, so it can't be pinned in a snapshot without becoming flaky across machines/runners with a different CPU allocation. Added it to the existing platform-noise filter in scripts/normalize_integration_logs.sh instead of baking the value in.
  • Node 24's thrown-error payload now includes a requestId field that wasn't there before. This is not new or host-dependent: the existing per-case filter in integration_tests_local/run.sh already redacts requestId to XXXX, and the Node 26 golden (manual-throw-error_node26.json) already includes it. Node 24's golden had simply not been refreshed. Regenerated just that snapshot.

Motivation

Discovered while investigating unrelated CI failures on #840

Testing Guidelines

Reproduced all four originally-failing combinations locally against the fresh base images (nodejs22.x/nodejs24.x, amd64/arm64) and confirmed they pass after this fix. Re-ran nodejs18.x/20.x/26.x to confirm no regressions.

Additional Notes

N/A

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ea318c7 | Docs | View more details | Give us feedback!

@CarlesDD
CarlesDD marked this pull request as ready for review September 25, 2026 14:03
@CarlesDD
CarlesDD requested review from a team as code owners September 25, 2026 14:03

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants