Repository navigation
Read CatRange predictions returned as class ranges - #62
Merged
Merged
Conversation
CatRange predicts a class of kcat values, which OpenKineticsPredictor
returns as its range ("10 to 100 s^-1") in the column "Predicted kcat
range: kcat (1/s)". parse_okp_output required a column named exactly
"kcat (1/s)" and so rejected CatRange results. It now takes the one
column ending in "kcat (1/s)" and reads a range as its geometric
midpoint, or half the upper bound for the class starting at 0. The list
of available predictors is updated.
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CatRange predicts a class of kcat values. OpenKineticsPredictor returns it as the class range (
10 to 100 s^-1) in the columnPredicted kcat range: kcat (1/s).parse_okp_outputrequired a column named exactlykcat (1/s)and so rejected CatRange results.It now takes the one column ending in
kcat (1/s)and reads a range as its geometric midpoint, or half the upper bound for the class starting at 0 (0 to 1e-08 s^-1gives 5e-9). Plain numbers are read as before. Theokp.methoddescription lists all available predictors, CatRange included.New tests cover a CatRange result and the value parsing. The full suite passes (1,454 passed;
develophas 1,447).The same fix for GECKO: SysBioChalmers/GECKO#487