Repository navigation
Read CatRange predictions returned as class ranges - #2
Merged
Merged
Conversation
CatRange predicts a class of kcat values, which OpenKineticsPredictor
returns as its range ('10 to 100 s^-1') in the column 'Predicted kcat
range: kcat (1/s)'. readOpenKineticsPredictorOutput read that text as
NaN and dropped every CatRange prediction. It now reads a range as its
geometric midpoint, or half the upper bound for the class starting at 0.
The list of available predictors is updated.
Original-commit: SysBioChalmers/GECKO@a8292f9
Unit test results61 tests 61 ✅ 11s ⏱️ Results for commit 5f9b88d. ♻️ This comment has been updated with latest results. |
edkerk
force-pushed
the
fix/okp-catrange-ranges
branch
from
October 16, 2026 23:52
4910813 to
5f9b88d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from SysBioChalmers/GECKO#487, opened by edkerk on 2026-10-15.
CatRange predicts a class of kcat values. OpenKineticsPredictor returns it as the class range (
10 to 100 s^-1) in the columnPredicted kcat range: kcat (1/s), andreadOpenKineticsPredictorOutputread that text as NaN, dropping every CatRange prediction.A range is now read as its geometric midpoint, or half the upper bound for the class starting at 0 (
0 to 1e-08 s^-1gives 5e-9). Plain numbers are read as before. The list of available predictors insubmitOpenKineticsPredictornow includes CatRange, OmniESI, OmniESI-O2DENet and TurNuP.testReadOpenKineticsPredictorCatRange_tc0069reads a CatRange result. All 61 unit tests pass (MATLAB R2023a, RAVENdevelop3, GLPK).The same fix for geckopy: CompMetEng/geckopy#62