Repository navigation
Fix Renovate package rules not matching and request review on PRs - #453
Merged
Merged
Conversation
jimboid
approved these changes
Oct 13, 2026
jimboid
left a comment
Member
There was a problem hiding this comment.
Looks like it should work. Lets merge and see
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Renovate configuration so that dependency updates follow the intended
widenstrategy, and so that review is requested from maintainers instead of assigning them.Changes
Fix package rules matching:
matchManagerson bothpyproject.tomlpackage rules from["pep621"]to["poetry", "pep621"]. Renovate processes ourpyproject.tomlwith thepoetrymanager, so the previous rules never matched.pep621in the list so the rules still apply if the file is routed back to that manager.Request review instead of assigning:
assigneeswithreviewersforharryswift01andjimboid, so Renovate PRs request their review.Impact
widen, so only the upper bound of each version range moves and lower bounds (floors) are preserved.