Pick up the parser's OpenSCAD-matching library search; 1.23.0 - #183
Merged
Merged
Conversation
openscad_cpp_parser#10 fixes three ways findLibraryFile() missed a library OpenSCAD itself finds (BelfrySCAD #503): OPENSCADPATH replaced the default libraries folder instead of preceding it, Windows assumed %USERPROFILE%\Documents rather than asking for the real My Documents that OneDrive relocates, and libraries shipped beside the binary were never searched. The not-found error now lists every directory tried. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule bump to openscad_cpp_parser #10, plus the version bump for the release that carries it.
The parser missed libraries OpenSCAD itself finds, in three ways — reported as BelfrySCAD#503, where
include <BOSL2/std.scad>failed:OPENSCADPATHreplaced the default libraries folder instead of being searched before it, so setting it for one library hid every other.%USERPROFILE%\Documents; OneDrive's Known Folder Move puts the real My Documents elsewhere. It now asks Windows, as OpenSCAD does.The not-found error also lists every directory it tried, instead of naming only the includer.
Verified against this bump: 1270 C++ tests, 22/22 Python binding tests, and BelfrySCAD's own 1802.
🤖 Generated with Claude Code