Link ${CMAKE_DL_LIBS} for the parser's dladdr; 1.23.1 - #184
Merged
Merged
Conversation
openscad_cpp_parser#11. v1.23.0's wheel build failed to link on both manylinux legs -- "undefined reference to dladdr" -- because glibc there still keeps dl in a separate library. macOS and Windows carry it in libSystem/kernel32, so every local build and both of those CI legs linked fine. Nothing published, so v1.23.0 is a dead tag. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submodule bump to openscad_cpp_parser #11, plus the version bump for the release that carries it.
v1.23.0's wheel build failed to link on both manylinux legs —
undefined reference todladdr'— because AlmaLinux 8's glibc still keepsdl` in a separate library. macOS and Windows carry it in libSystem/kernel32, so every local build and both of those CI legs linked fine.Nothing was published from that tag (the publish jobs need all five wheels), so v1.23.0 is a dead tag and this releases as 1.23.1. Everything in #183 ships with it.
1270 C++ tests pass against this bump.
🤖 Generated with Claude Code