Repository navigation
Channel part of an entry's URL accepts the wildcards * and ? - #10503
Merged
Merged
Conversation
#03_RapidRAW*ubuntu-24.04 picks 03_RapidRAW_v1.6.6_ubuntu-24.04_amd64.AppImage but not the 03_tethering_RapidRAW build of the same release (#10502): with a wildcard the pattern may match anywhere in the tag or file name; without one the whole-word matching of #nightly and the like is unchanged. worker.sh and check-entry.sh let * and ? through to find-appimage.sh. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10502 (comment): RapidRAW's release has four AppImages (
03_RapidRAW_…and03_tethering_RapidRAW_…, each for Ubuntu 22.04 and 24.04), so the repository URL alone is ambiguous. The#wordat the end of an entry's URL (used for#esr,#nightly) matches whole words of the tag or file name, so#ubuntu-24.04still leaves two candidates, and a single word cannot say "the plain build, for 24.04".Wildcards.
*(any characters) and?(one character) are now allowed in the#part. With a wildcard the pattern may match anywhere in the tag or file name (so no leading and trailing*are needed); without one, the whole-word matching of#nightlyand the like is unchanged.find-appimage.shbuilds the regular expression (dots escaped),worker.shandcheck-entry.shlet*and?through when they read the part after the#; every other character is still dropped.Tested on the four names of the log:
#part03_RapidRAW*ubuntu-24.0403_RapidRAW_v1.6.6_ubuntu-24.04_amd64.AppImage*tethering*22.04*03_tethering_RapidRAW_v1.6.6_ubuntu-22.04_amd64.AppImage03_RapidRAW*ubuntu-2?.04nomatch*So the two RapidRAW entries can be
https://github.com/CyberTimon/RapidRAW#03_RapidRAW*ubuntu-24.04and…#03_tethering*ubuntu-24.04, which stays valid for new versions. README and AGENTS.md describe it.bash -nand shellcheck pass.?as a separator before the#is not supported and not needed.Generated by Claude Code