Repository navigation
Conversation
escapeValue: false would leave interpolated values unescaped if a translation were ever rendered outside React's JSX escaping. Signed-off-by: js665999 <js665999@broadcom.com>
|
Member
|
Do you have an example of a bad value and how this corrects it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
With escapeValue: false, interpolated values are emitted unescaped. Nothing is exploitable today: every translation is rendered through JSX text nodes, which escape output, and no dangerouslySetInnerHTML exists in webClient/src. The risk is latent. If a translation is later rendered through dangerouslySetInnerHTML or a direct DOM write, externally influenced values (for example status text received from other desktop plugins) would go out unescaped. This is a sample app that others copy, so the safer default is the better one.