Fix color mode: only persist explicit choice, follow system theme - #380
Open
Edward-Deakin wants to merge 1 commit into
Open
Edward-Deakin wants to merge 1 commit into
Edward-Deakin wants to merge 1 commit into
Conversation
The resolved mode was written to localStorage on every load, freezing the system default (or a URL param theme) into a stored choice that overrode later system preference changes. Persist only on explicit user set/toggle, don't persist the URL param, and follow live prefers-color-scheme changes when no choice is stored. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Edward-Deakin
force-pushed
the
fix/color-mode-url-theme-override
branch
from
September 21, 2026 16:55
5bd1352 to
0a5b1be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Auto theme switching defaulted to a stale value in `localStorage`. The provider wrote the resolved mode to `localStorage.theme` on every load, so the system `prefers-color-scheme` default (or a `?docusaurus-theme=` URL param) became a stored "choice" that overrode later system changes.
Fix (`packages/docs-ui/src/providers/ColorMode`)
Notes
🤖 Generated with Claude Code