You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request introduces a new GitHub Actions workflow to automate updating the Homebrew tap formula for the project upon each release. The workflow calculates the release tarball's SHA-256 checksum, updates the gitid.rb formula in the homebrew-tap repository, and pushes the changes automatically.
Release automation:
Added a .github/workflows/release-tap.yaml workflow that triggers on release publication, computes the release tarball SHA-256, updates the gitid.rb formula in the homebrew-tap repository with the new tag and checksum, and commits the changes automatically.
Adds a release-triggered GitHub Actions workflow to update and push the Homebrew tap formula.
Changes:
Computes the release tarball SHA-256 checksum.
Updates gitid.rb with the release tag and checksum.
Commits and pushes changes to homebrew-tap.
File
Summary
.github/workflows/release-tap.yaml
Adds release automation. Findings include unsafe shell interpolation of the release tag (critical), insufficient curl error handling, silent formula-update failures, and concurrent-release push conflicts.
The tag is placed unescaped in the replacement part of a sed expression. Valid Git ref names can contain characters such as & and |; & expands to the entire matched URL and | breaks the command, so publishing such a tag can produce an invalid formula or fail the job. Escape replacement metacharacters before substitution (or use a parser).
Escape Git tag metacharacters before sed substitution
.github/workflows/release-tap.yaml:44
A valid Git tag can contain & (and |), but interpolating it directly into the sed replacement makes & expand to the entire matched URL and | terminate the replacement. For example, v1.0.0&beta produces a malformed formula URL, so releases using those tag names will commit an unusable formula. Escape sed replacement metacharacters (or update the formula with a structured script) before substituting the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new GitHub Actions workflow to automate updating the Homebrew tap formula for the project upon each release. The workflow calculates the release tarball's SHA-256 checksum, updates the
gitid.rbformula in thehomebrew-taprepository, and pushes the changes automatically.Release automation:
.github/workflows/release-tap.yamlworkflow that triggers on release publication, computes the release tarball SHA-256, updates thegitid.rbformula in thehomebrew-taprepository with the new tag and checksum, and commits the changes automatically.