Bump the vendored engine and coffeecatch to their masters - #238
Merged
Merged
Conversation
The engine moves 40 commits past 3.50.4, and coffeecatch picks up a JNI local-reference leak fix and an atomic session refcount. HTTRACK_VERSIONID is still 3.50.4, so versionName does not move. The engine split its self-tests into one file per module, so Android.mk now lists the new hts*_selftest.c sources. Without them htsselftest.c has no selftests_* table to point at, and libhttrack does not link. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Engine #1777 made htscoremain.c clip an over-limit --max-retry-after and log a notice, where it used to panic and return -1. Three comments still gave the panic as the reason for our own 3600 ceiling and for dropping an out-of-range value. The ceiling and the dropping are unchanged. The stray-sign claim on the "+60" case is left alone. It was already inaccurate before this bump, so it is not this bump's to fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
"Clips or refuses" is false for -%J60s. The engine stores 60, then reads the leftover 's' as -s, so robots.txt obedience drops from ALWAYS to SOMETIMES with no panic and no clip. The test name and its assertion message claimed the same refusal, so both change with it. Two more comments on CappedOption still gave the old panic as the reason for our ceiling. The earlier sweep missed them by piping its grep through head. The test comment now also says what dropping buys, which is the engine's 60s default rather than its 3600s ceiling. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine moves 40 commits past 3.50.4, and coffeecatch picks up a JNI local-reference leak fix and an atomic session refcount.
HTTRACK_VERSIONIDis still3.50.4, soversionNamedoes not move.The engine split its self-tests into one file per module, so
Android.mknow lists the newhts*_selftest.csources. Without themhtsselftest.chas noselftests_*table to point at, andlibhttrackdoes not link.The engine also clips an over-limit
--max-retry-afterwhere it used to panic. Comments giving that panic as our reason for capping at 3600 are corrected. The case worth knowing is-%J60s. The engine stores 60, then reads the leftoversas-s, which quietly weakens robots.txt obedience. That is why the app drops such a value instead of passing it on, and neither the cap nor the dropping changes here.