Bump the vendored engine to 3.50.4, so a crawl obeys Retry-After on a 429 or a 503 - #235
Merged
Merged
Conversation
HTTRACK_VERSIONID moves 3.50.2 -> 3.50.4, so the versionName prefix is realigned. versionCode stays 105, because this is not a release. Verified against the pin rather than the release note: no .c or .h was added under src/, so Android.mk needs no entry; the six calls that lost HTSEXT_API are the complete de-export set and this front end calls none of them; every engine symbol htslibjni.c uses is still exported. Both ABIs build and the 526 unit tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
versionCode 105 was already tagged as v3.50.2.105 and shipped, so an upload reusing it would be refused by Play. 106 is free. The release notes still opened "HTTrack 3.50.2" in all 29 locales, which would have gone out as this release's text. Rewritten for 3.50.4 against the engine delta: the Retry-After hold on a 429 or a 503, the JavaScript module imports that are now followed, the robots.txt group fix, and the crash fixes on the cache-repair and charset paths. Every locale validates through tools/ci/play_track_admin.py load_notes() and stays under the 500-character cap. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
xroche
changed the title
The release is split out so this PR carries only the engine pin. The versionCode bump and the rewritten release notes return in their own PR, after the --max-retry-after field lands, so one release ships both. This reverts commit d1ecf66. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
xroche
changed the title
xroche
enabled auto-merge (squash)
September 25, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTRACK_VERSIONIDmoves from 3.50.2 to 3.50.4, so theversionNameprefix follows it.versionCodestays 105, because this is not a release.The engine now retries a 429 or a 503 and obeys
Retry-After. Users here get it with no option wired:hts_create_opt()caps the hold at 60 seconds by default, and this front end calls it. The two new options,--mptcpand--max-retry-after, are not wired here.No engine source was added, so
Android.mkneeds no entry. Six functions lostHTSEXT_APIand left the export table oflibhttrack.so. This front end calls none of them, and every engine symbolhtslibjni.cdoes use is still exported.