Conversation
dawNotPoi
marked this pull request as ready for review
September 24, 2026 18:41
Contributor
Author
|
@xintaofei Ready for review. This fixes #698: task drafts now accept a title, description, or attachment alone. A title-only brief becomes a real Agent prompt; reopening and editing preserve the intended prompt, references, and attachments. Legacy image-only tasks and templates remain image-only, and removing the last attachment requires a real instruction. Independent review found and resolved the edit round-trip cases. All 7 latest CI jobs passed across frontend and Rust on Linux, Windows, and macOS; focused task-editor tests: 33 passed, i18n tests: 19 passed. Thanks! |
dawNotPoi
force-pushed
the
fix/task-single-field-698
branch
from
September 28, 2026 07:04
51d51f4 to
95b03b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698.
What changed
brief_originmetadata so reopening a generated brief does not mistake its generated fields for user-entered text. Title-only edits rebuild the instruction from the current title; untouched attachment-only edits keep only attachments; description-derived titles follow the first line until the title is explicitly edited.Compatibility
WorkTaskDraft.configandWorkTaskInfo.configare opaqueserde_json::Valuefields. The service stores and returns their JSON directly on create/get/update; template save/read does the same. The RustWorkTaskConfiguses tolerant serde defaults and ignores the optional editor-only field during validation and launch. Older configs without the marker remain readable.Verification
51d51f42: focused task-editor suite 33 passed; i18n suite 19 passed;pnpm lint .passed;pnpm buildpassed.5ddc4ff3: 520 files, 7,790 tests passed. Latest CI on this head passed all 7 jobs (frontend and Rust server/desktop across Linux, Windows, and macOS): https://github.com/xintaofei/codeg/actions/runs/36038709483.