Conversation
dawNotPoi
marked this pull request as ready for review
September 24, 2026 16:39
Contributor
Author
|
@xintaofei 已转 Ready,请审阅。这个 PR 为 #807 增加可验证的手动恢复:根据 Agent 的实际事件提示长时间静默,不把保活流量当作进展;由用户明确发起重启,只终止对应 ACP 子进程,确认旧进程退出后恢复原 session,桌面和 Web 均支持。独立复审已完成;本地前端 7,788 项测试、Rust server 4,296 项测试通过,最新提交 ecc68b3 的 7 项 CI 全绿。范围是可观察性和手动恢复,不自动判定 Agent 已死亡,也不修改 agy compaction 或通用取消语义。 |
dawNotPoi
marked this pull request as draft
September 24, 2026 23:09
dawNotPoi
marked this pull request as ready for review
September 24, 2026 23:54
Contributor
Author
|
@xintaofei #831 已根据独立复审修复两处 restart 竞态并转回 Ready:普通断开或终止错误先于重启预留完成时,不会留下阻断同一 session 重连的隔离状态。两个顺序都有确定性回归测试;最新提交 b954c18 的 7 项 CI 全绿,PR 描述已更新。烦请有空审阅。 |
dawNotPoi
force-pushed
the
fix/acp-stalled-restart
branch
from
September 28, 2026 07:04
b954c18 to
ab6ff5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A long prompt can be healthy, so restart remains a user decision.
Verification
b954c18c: all seven CI jobs pass across frontend and Rust desktop/server on Linux, macOS, and Windows.Scope
This adds stall visibility and manual recovery. It does not automatically terminate an agent or change general cancel semantics. Provider compaction behavior remains outside this PR.
Addresses #807.