Conversation
dawNotPoi
marked this pull request as ready for review
September 24, 2026 07:00
Contributor
Author
|
@xintaofei Ready for review. This fixes #600 by persisting ACP session errors for cold Web/mobile detail loads and restarts, while keeping live Alerts deduplicated through fork and reconnect. S1 error identity and event ordering survive both fork orderings, so dismissed alerts stay dismissed and older events cannot overwrite newer errors. Independent review found no blocker; all seven CI checks passed on c94d4b7, alongside 4,291 Rust and 7,747 frontend tests locally. Scope limits and the untested physical phone path are documented in the PR body. I would appreciate your review. |
dawNotPoi
force-pushed
the
fix/acp-persist-last-error
branch
from
September 28, 2026 07:05
c94d4b7 to
d554868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #600.
Verification
Scope and limits
An error is recoverable after backend restart and cold Web/mobile detail load once its event is committed to SQLite. A process crash before receipt or commit cannot be recovered. Old pre-migration rows normalized to parser branch IDs have no stored ACP UUID to backfill: successful session/load with the known branch ID stays on the row, while a failed load that falls back to a new Gemini ACP UUID splits to a new row because built-in agents provide no transcript continuation. An unknown old UUID cannot be inferred safely. The project assumes one backend process per SQLite data root. The shared API and UI state were tested, but no physical phone was manually tested.