Refresh expired wolfSSL example CA certs and add a refresh script - #601
Open
aidangarske wants to merge 1 commit into
Open
Refresh expired wolfSSL example CA certs and add a refresh script#601aidangarske wants to merge 1 commit into
aidangarske wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The refresh script’s default WOLFSSL_DIR resolution is cwd-dependent (can break when invoked from outside the repo root), and the new script may not be included in dist artifacts despite being referenced in the README.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refreshes the bundled wolfSSL example CA certificates used by wolfTPM’s TLS examples (to avoid failures due to expiration) and adds a helper script so contributors can refresh them from a local wolfSSL checkout.
Changes:
- Updated the bundled wolfSSL example CA certs (
wolf-ca-rsa-cert.pem,wolf-ca-ecc-cert.pem) to non-expired versions. - Added
certs/refresh-wolf-ca.shto copy refreshed CA certs from a wolfSSL checkout. - Documented the refresh script usage in
examples/README.md.
File summaries
| File | Description |
|---|---|
| examples/README.md | Documents how to refresh the bundled wolfSSL example CA certs via the new script. |
| certs/wolf-ca-rsa-cert.pem | Replaces the expired RSA example CA cert with a renewed one. |
| certs/wolf-ca-ecc-cert.pem | Replaces the expired ECC example CA cert with a renewed one. |
| certs/refresh-wolf-ca.sh | Adds a script to refresh the bundled CA certs from a wolfSSL checkout. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+14
to
+16
| WOLFSSL_DIR="${WOLFSSL_DIR:-../wolfssl}" | ||
| SCRIPT_DIR=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd) | ||
|
|
Comment on lines
+174
to
+175
| Or run `./certs/refresh-wolf-ca.sh` (set `WOLFSSL_DIR` if wolfSSL is not | ||
| at `../wolfssl`) to refresh them when they expire. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
certs/wolf-ca-rsa-cert.pem and certs/wolf-ca-ecc-cert.pem expired on Sep 8 2026 22:19 GMT updates cert - update the CA certs so CI doesnt fail