Repository navigation
fix(websocket): preserve JOIN ordering during target handoff - #964
Merged
Merged
Conversation
skhaz
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
The websocket read goroutine can send a command to the newly published target before its JOIN notification. An in-flight old-target send can also finish after LEAVE. Connected-client ownership enforcement in wippyai/framework#176 correctly rejects both out-of-order commands.
Fix
Serialize command enqueueing and handoff notifications with a private connection mutex. Complete topology preparation outside that mutex, enqueue LEAVE/JOIN in per-sender FIFO, and publish the new target and optional message topic only after JOIN is accepted. State-only controls remain independent of relay backpressure.
Canceled handoffs release the newly acquired monitor. Failed JOIN closes the connection instead of retaining an unjoined target; failed LEAVE still permits a reachable replacement. Failed sends release sender-owned relay packages.
Compatibility
Existing target, message-topic, metadata and heartbeat configuration fields retain their meaning. Client PIDs, wire payloads and normal connected-client routing are preserved. This changes failed-JOIN handling from a silent broken connection to closure. The serializer is internal; it adds no process option or host configuration.
Verification
Deploy the fixed runtime before rolling out the strict relay ownership guard in framework#176.