feat(app): isolate explicit client launch from owner execution - #703
Open
wolfy-j wants to merge 3 commits into
Open
feat(app): isolate explicit client launch from owner execution#703wolfy-j wants to merge 3 commits into
wolfy-j wants to merge 3 commits into
Conversation
This was referenced Sep 9, 2026
wolfy-j
marked this pull request as ready for review
September 9, 2026 21:45
skhaz
approved these changes
Sep 10, 2026
wolfy-j
force-pushed
the
feat/application-launch-admission
branch
from
September 10, 2026 23:37
0851129 to
8016b46
Compare
skhaz
approved these changes
Sep 11, 2026
Contributor
Author
|
Polished cmd/app in d6937ee: validate all data-environment bindings before applying any, reject NUL paths, preserve explicit empty overrides, and check cancellation before creating owner state. Added regression tests; 10 race repetitions and scoped lint pass. Merged current main to include the approved shutdown/WebSocket fixture corrections. No exported API added. Bee integration remains a merge gate: the inspected native launcher still uses api/application.PrepareLaunch/LaunchPlan and must move to the explicit cmd/app callback. No compatibility claim for that old native wiring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Let a Builder-produced executable select an application-specific client or owner invocation without changing ordinary Wippy runtime semantics.
Design
cmd/app, following chore: keep native application code under cmd #727. Noapi/application, public statelock package, Lua API, or boot-component discovery is added.Options.Launchis an explicit native callback. It can run a client directly or call the one-shot, scoped owner runner. The application owns discovery, authentication, admission and attachment errors.app.ErrBusy; filesystem errors are not contention. No automatic attachment, retry, or owner fallback occurs.#726's embedded-baseline selection is a separate application option, not a launch result. Builder and Bee need corresponding explicit wiring; the former implicit
PrepareLaunchcomponent integration is intentionally removed. Do not merge until those integration checks are complete.Validation
go test -race ./cmd/app -count=10passes../cmd/app/...: zero issues.cmd/app; no docs or README files added to the repository.