Repository navigation
fix(relay): preserve sessions through disconnect grace - #180
Merged
Merged
Conversation
skhaz
approved these changes
Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last client LEAVE currently sends session shutdown immediately. A short transport interruption can therefore finish the user's sessions before reconnection. This change delays that signal by one second; JOIN cancels the pending signal and resumes the existing plugin. Live updates retain the original disconnect time and reconstruct the remaining grace.
Integrated with #179: reconnect clears both idle retirement and pending disconnect shutdown. The timer stops on reconnect, upgrade and process exit. Client ownership checks and older upgrade snapshots remain supported; exited-child shutdown delivery failures are logged without stopping the hub.
Validation on signed Wippy v0.3.48a:
Companion: wippyai/session#65 (merged). Deploy with its cooperative turn-drain behavior; #179 handles collection after the hub inactivity timeout. No UI changes. This merge does not release or publish modules.