Skip to content

Fix verify exit status for skipped testcases with failures or errors - #184

Open
zombieli wants to merge 1 commit into
weiwei:masterfrom
zombieli:fix/verify-mixed-results
Open

zombieli wants to merge 1 commit into
weiwei:masterfrom
zombieli:fix/verify-mixed-results

Conversation

@zombieli

Copy link
Copy Markdown

A testcase can contain both skipped and error results, for example when pytest skips the test body but its fixture teardown fails. verify currently returns success for that report.

Check is_failure or is_error directly and add regression cases covering mixed results in both orders, plus passed and skipped-only controls.

Validation: Windows / Python 3.11.7, pytest 9.1.1. Full suite: 137 passed, 8 skipped with stdlib ElementTree; 139 passed, 6 skipped with lxml 6.1.3. Ruff 0.15.12 check and format check, and git diff --check passed. A real pytest skipped-plus-teardown-error report changes verify from 0 to 1. Platform-specific skips remain; remote CI has not run.

No issue has been filed yet. AI assistance was used for investigation, implementation, and test execution; the account owner is reviewing the patch before submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant