fix(ios): run surface transitions on main thread - #459
Open
AlirezaHadjar wants to merge 2 commits into
Open
AlirezaHadjar wants to merge 2 commits into
AlirezaHadjar wants to merge 2 commits into
Conversation
AlirezaHadjar
marked this pull request as ready for review
August 27, 2026 21:03
Owner
|
Thank you for this, I need to think about it a bit more deeper |
Owner
|
@AlirezaHadjar just wanted to tell you that I am not dropping this issue. Currently looking at the same issue on Skia Graphite, once we fix there, I will circle back on this one. It just need a bit of more designing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458.
Moves Apple surface transitions to the main thread and retains detached surface state until the frame that acquired it reaches present. This fixes Core Animation thread confinement and prevents teardown from racing
getCurrentTexture()/queue.submit().Validated on an iPhone 16 Pro Max with five 60-second Xcode Activity Monitor runs and 750 total remounts: