Fix macOS release signing keychain unlock failure - #100
Merged
Merged
Conversation
Upgrade electron-builder to 26.16.1 so CSC_LINK signing passes the temporary keychain password to security set-key-partition-list instead of the .p12 import password. macOS 26.6 rejects the wrong password; 26.15.3 worked only while older runners still accepted it. Co-authored-by: Wassim Gharbi <wassgha@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wassgha
marked this pull request as ready for review
September 14, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS release jobs started failing on
set-key-partition-listwithSecKeychainUnlock: The user name or passphrase you entered is not correctbeginning withv1.1.14/v1.2.0. Windows and Linux still succeed.This is not a bad
CSC_KEY_PASSWORDsecret. It is electron-builder#10066:26.15.3passes the.p12import password tosecurity set-key-partition-list -k, but that flag needs the temporary keychain's own password. Older GitHub macOS runners (os=25.5.0) still accepted the wrong password; newer ones (os=25.6.0) reject it.Fix
Upgrade
electron-builderto^26.16.1, which includes the backport of #10101 (fix(mac): use keychain password for set-key-partition-list).After merge
Re-cut a release (
npm run cut:patch→v1.2.1) so the tag points at a commit that includes this upgrade. Re-running the existingv1.2.0tag alone will still build the old lockfile.Evidence
Test plan
app-builder-lib@26.16.1passeskeychainPasswordintoset-key-partition-listv1.2.1; confirm the macOSBuild and Releasejob signs and notarizes successfully