Repository navigation
Conversation
… + original transliteration table - Drop the joomla/string dependency (GPL-2.0-or-later, incompatible with this MIT package). Its StringHelper was a thin pass-through to mbstring for every method used here, so call mb_substr/mb_strtolower/mb_strlen/ mb_strpos/mb_strrpos directly across StemmerFactory and all Stemmer classes. composer.json now requires ext-mbstring instead. - Rewrite src/Transliterate.php's accent-folding table. It was a verbatim copy of Joomla's transliterate class, itself a port of phputf8's utf8_accents_to_ascii() — traceable to fluxbb/utf8, which is LGPL-2.1. Re-derived the same 105 lower / 103 upper mappings independently from each character's Unicode identity (canonical decomposition for diacritics, standard romanization convention for ß/þ/ð/æ/œ/ø/ł/đ/ħ/ƒ/µ and the German umlauts), matching Unicode CLDR's Latin-ASCII/de-ASCII transforms rather than any single third-party table. - Update README's PHP 8.4 install note to explain the actual rationale chain (voku/portable-utf8 -> joomla/string -> native mbstring) instead of the outdated "avoid deprecated" framing.
Collaborator
|
please look at https://github.com/wamania/php-stemmer/tree/5.0-dev this already has the GPL dependency removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the joomla/string dependency (GPL-2.0-or-later, incompatible with this MIT package). Its StringHelper was a thin pass-through to mbstring for every method used here, so call mb_substr/mb_strtolower/mb_strlen/ mb_strpos/mb_strrpos directly across StemmerFactory and all Stemmer classes. composer.json now requires ext-mbstring instead.
Rewrite src/Transliterate.php's accent-folding table. It was a verbatim copy of Joomla's transliterate class, itself a port of phputf8's utf8_accents_to_ascii() - traceable to fluxbb/utf8, which is LGPL-2.1. Re-derived the same 105 lower / 103 upper mappings independently from each character's Unicode identity (canonical decomposition for diacritics, standard romanization convention for ß/þ/ð/æ/œ/ø/ł/đ/ħ/ƒ/µ and the German umlauts), matching Unicode CLDR's Latin-ASCII/de-ASCII transforms rather than any single third-party table.
Update README's PHP 8.4 install note to explain the actual rationale chain (voku/portable-utf8 -> joomla/string -> native mbstring) instead of the outdated "avoid deprecated" framing.