Repository navigation
ci: repin dtolnay/rust-toolchain to where v1 points now - #567
Merged
Merged
Conversation
The action's v1 tag moved again on 2026-10-09 at 01:48 UTC, from 7e38f4b4 to e2a55d2f, when upstream merged its PR 187. zizmor's online audits fail every use since: the `# v1` comment no longer names the pinned commit (ref-version-mismatch, medium) and the commit no longer points at a tag (stale-action-refs). The 16 pins in five workflows move to e2a55d2ffb04. The SHA was read from `gh api repos/dtolnay/rust-toolchain/commits/v1`, and the tag object is the commit itself. Upstream changed one file, action.yml, in two commits by dtolnay with valid signatures. The commits pass toolchain, targets and components to the shell through env: instead of interpolating them into run: (input-injection hardening, upstream issue 179). There is no new input and no network call. Signed-off-by: Vyncint Ng <115854244+vyncint@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The action's
v1tag is a moving tag. On 2026-10-09 at 01:48 UTC it movedfrom 7e38f4b4 to e2a55d2f when upstream merged dtolnay/rust-toolchain#187.
zizmor's online audits now fail every use: the
# v1comment no longernames the pinned commit (ref-version-mismatch, medium), and the commit no
longer points at a tag (stale-action-refs). Main's last CI ran before the
move, on 2026-10-07; the first run after it, on #566, is red on
zizmoralone, and #566 touches no workflow.
The 16 pins in five workflows move to e2a55d2ffb04. The SHA was read from
gh api repos/dtolnay/rust-toolchain/commits/v1, and the tag object is thecommit itself. Between the two commits upstream changed one file,
action.yml(+29/−20), in two commits by dtolnay, both with validsignatures. They pass
toolchain,targetsandcomponentsto the shellthrough
env:instead of interpolating them intorun:, which isinput-injection hardening for upstream issue 179. There is no new input and
no network call.
Local
zizmor --offline --persona=pedantic .github/(1.29.0): no findings.The online audits that caught this run only in CI.
Checklist
cargo fmt --allandcargo clippy --workspace --all-targets --all-featuresare clean (no Rust changed)git commit -s) — see CONTRIBUTING.md §5CHANGELOG.mdupdated under[Unreleased](user-facing changes only): n/a, not user-facingcargo insta review, not blind-accepted: none