Repository navigation
fix(buffer): default implicit responses to HTTP 200 - #263
Merged
Merged
Conversation
ldez
self-requested a review
October 8, 2026 01:03
ldez
force-pushed
the
fix-buffer-default-status
branch
from
October 8, 2026 10:31
c5962af to
6f7c6ef
Compare
ldez
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapping a handler that only calls Write, or returns without writing, leaves the buffered response status at zero. Buffer then calls WriteHeader(0) and panics.
Each response buffer now starts with HTTP 200. Explicit statuses still override that value, and retry predicates see the default status for every attempt.
Eight regression cases cover implicit responses, HEAD requests and status-based retries. All eight panic with the original source.